Skip to content

pub GraphInfo #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2025
Merged

pub GraphInfo #20149

merged 4 commits into from
Jul 22, 2025

Conversation

mrchantey
Copy link
Contributor

@mrchantey mrchantey commented Jul 15, 2025 •
edited
Loading

IntoScheduleConfigs has the constraint T: Schedulable<Metadata = GraphInfo, GroupMetadata = Chain>. Making GraphInfo public allows external crates to implement blanket traits for any IntoSheduleConfigs:

pub struct ScheduleIntoMyTraitMarker;

impl<S, T, M> MyTrait<(ScheduleIntoMyTypeMarker, T, M)> for S
where
  S: 'static + Clone + IntoScheduleConfigs<T, M>,
  T: Schedulable<Metadata = GraphInfo, GroupMetadata = Chain>,
{
}

@mrchantey mrchantey added A-ECS Entities, components, systems, and events D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 15, 2025
@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 15, 2025
@alice-i-cecile alice-i-cecile enabled auto-merge July 21, 2025 22:54
@BD103
Copy link
Member

BD103 commented Jul 22, 2025

@mrchantey looks like you just need to run cargo fmt to fix CI, then this can be merged :)

auto-merge was automatically disabled July 22, 2025 04:02

Head branch was pushed to by a user without write access

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 22, 2025
Merged via the queue into bevyengine:main with commit 5bb8f29 Jul 22, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@ItsDoot ItsDoot ItsDoot approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrchantey @BD103 @alice-i-cecile @ItsDoot